-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed redundant _texts variables. #133
Conversation
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
- Coverage 63.31% 61.68% -1.63%
==========================================
Files 8 8
Lines 766 770 +4
==========================================
- Hits 485 475 -10
- Misses 281 295 +14
Continue to review full report at Codecov.
|
..addStatusListener(_animationEndCallback); | ||
_typewriterText = StepTween( | ||
begin: 0, | ||
end: textLen + 8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anybody know why 8 is being added? What is significant about 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8
is added for the _
typing animation after the given text is animated or typed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 8 and not 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk it's a random number that I added at the time of development, a lot of code has been changed after that.
Investigating #128 led me to realize that |
@awhitford, your suggested changes look good to me, great work! 💯 |
_timer
variable so that it can be properly canceled duringdispose
._texts
variables.